BUG: Series.rename(scalar, copy=False) still copies data #52540
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyi96
commented
Apr 8, 2023
| # 2) If inplace is False/not supplied(default case), then | ||
| # inplace is determined based on copy (opposite of copy) | ||
| if not inplace: | ||
| inplace = not copy | ||
| return self._set_name(index, inplace=inplace) |
There was a problem hiding this comment.
the gist of the issue is that _set_name ( in the else portion ) doesn't support copy param and solely relies on inplace param.
Hence the copy param supplied to rename is just ignored in this case.
Some possible solutions here would be -
- In the else portion, determine
inplacebased oncopy( in the case whereinplaceis False ) and then invoke_set_name - Support
copyandinplacein_set_nameand change its implementation similar torename
I guess approach 1 might work/be better ( subject to review )
|
as discussed in #52450
Hence am closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.