Add new test for None values on string columns on a Dataframe #52523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 7, 2023
| @@ -2698,6 +2698,14 @@ def test_frame_from_dict_with_mixed_tzaware_indexes(self): | |||
|
|
|||
|
|
|||
| class TestDataFrameConstructorWithDtypeCoercion: | |||
| def test_none_values_on_string_columns(self): | |||
There was a problem hiding this comment.
Can you move this to pandas/tests/indexing/test_loc.py in the class TestLoc class?
mroeschke
reviewed
Apr 7, 2023
| @@ -2698,6 +2698,14 @@ def test_frame_from_dict_with_mixed_tzaware_indexes(self): | |||
|
|
|||
|
|
|||
| class TestDataFrameConstructorWithDtypeCoercion: | |||
| def test_none_values_on_string_columns(self): | |||
| # Creating DataFrame with column "a" as string and a None value | |||
There was a problem hiding this comment.
These comments are not needed. Instead could you add a comment with the github issue number?
mroeschke
reviewed
Apr 7, 2023
| df = DataFrame(data=data, dtype="str") | ||
|
|
||
| # Checking that the value of the third row in column "a" is actually None | ||
| assert isna(df.loc[2, "a"]) |
There was a problem hiding this comment.
Suggested change
| assert isna(df.loc[2, "a"]) | |
| assert df.loc[2, "a"] is None |
There was a problem hiding this comment.
Greetings @mroeschke, i made the changes as requested
mroeschke
added
Testing
mroeschke
reviewed
Apr 8, 2023
pandas/tests/indexing/test_loc.py
Outdated
| def test_none_values_on_string_columns(self): | ||
| # Issue #32218 | ||
| data = {"a": ["1", "2", None]} | ||
| df = DataFrame(data=data, dtype="str") |
There was a problem hiding this comment.
From the issue df = pd.DataFrame(["1", "2", None], columns=["a"], dtype="str") should be the DataFrame being tested here
There was a problem hiding this comment.
Pre-commit check fails if i write pd.Dataframe, is it ok to write Dataframe instead?
mroeschke
approved these changes
Apr 10, 2023
|
Thanks @GrammatikakisDimitris |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Although this issue seems to be gone, i noticed in the comments that a test for this would be appreciated, so this basically checks that Dataframe behaves as it should.