ENH: Add inplace option to drop and dropna #5247
Conversation
|
I'll have a look tomorrow |
|
Updated the note to reflect that this still copies, it just updates the wrapper rather than changing the internals in place, so doesn't avoid "2X" problem referenced in #2325. |
| agg_axis_name = self._get_axis_name(agg_axis) | ||
| agg_obj = self.reindex(**{agg_axis_name: subset}) | ||
| else: | ||
| axis = self._get_axis_number(axis) |
There was a problem hiding this comment.
I know Panel overrides this method, but this is not safe...use get_block_manager_axis
There was a problem hiding this comment.
This is on DataFrame not generic, before I change, to be clear you mean changeagg_axis = 1 - axis to:
agg_axis = self._get_block_manager_axis(axis)
There was a problem hiding this comment.
sorry I thought it was on generic ; there is an agg_axis method somewhere (look at _reduce) - it gives same answer obviously but is more correct
There was a problem hiding this comment.
because of what it needs to do, I think it's actually clearer to leave as is (because it needs to pass the name to reindex, etc.), otherwise have to either add a _get_agg_axis_number method, or add another keyword argument to _get_agg_axis.
I'm fine with going with what you'd like to do though.
There was a problem hiding this comment.
going to keep as-is for now rather than create a separate method.
|
@jreback you okay with this now? |
|
ok |
ENH: Add inplace option to drop and dropna
And appropriately invalidates caches as necessary BUT still makes a copy. @jreback and I decided that it shouldn't call
__finalize__a second time in_update_inplace(so if metadata is supposed to change, it's not going to be updated, but subclass can always override it). Closes #1960, related #2325 (doesn't actually fix because still makes a copy).Adds
_update_inplacemethod that takes a result and invalidates the internal cache then reindexes.@jreback - would you mind taking a look? It's almost there, I think I'm
missing one cache reference or something... (or I'm just using reindex
wrong).