-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
PERF: groupby reductions with pyarrow dtypes #52469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
9528ffc
REF: move groupby reduction methods to EA
jbrockmendel 1ea4a72
REF: move EA-specific checks to EAs
jbrockmendel 8645cf1
REF: dont pass op to groupby_op
jbrockmendel ea40255
mypy fixup
jbrockmendel a2e7e64
groupby_op -> _groupby_op
jbrockmendel 6a2788b
Merge branch 'main' into ref-ea-gb-reductions-3
jbrockmendel ec58ebb
Merge branch 'main' into ref-ea-gb-reductions-3
jbrockmendel fcfd76d
Merge branch 'main' into ref-ea-gb-reductions-3
jbrockmendel a3f32d0
Merge branch 'main' into ref-ea-gb-reductions-3
jbrockmendel d80c0b2
mypy fixup
jbrockmendel c78af4d
Merge branch 'main' into ref-ea-gb-reductions-3
jbrockmendel 0248ce3
Merge branch 'main' into ref-ea-gb-reductions-3
jbrockmendel 2206dea
Merge branch 'main' into ref-ea-gb-reductions-3
jbrockmendel 335eb11
Merge branch 'main' into ref-ea-gb-reductions-3
jbrockmendel 2517eae
Merge branch 'main' into ref-ea-gb-reductions-3
jbrockmendel fab8725
mypy fixup
jbrockmendel dd5428e
Merge branch 'main' into ref-ea-gb-reductions-3
jbrockmendel 7a969a8
Merge branch 'main' into ref-ea-gb-reductions-3
jbrockmendel c93bf14
Merge branch 'main' into perf-arrow-gb
jbrockmendel b2f8536
Merge branch 'main' into perf-arrow-gb
jbrockmendel 7448e54
PERF: Groupby reductions with pyarrow dtypes
jbrockmendel 81cbd73
mypy fixup
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment on the issue, I think this can be optimized and simplified by reusing
__from_arrow__
(which usespyarrow_array_to_numpy_and_mask
under the hood)