BUG: segfault for null dtype in to_numpy #52466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 5, 2023
| @@ -1676,6 +1677,15 @@ def test_to_numpy_int_with_na(): | |||
| tm.assert_numpy_array_equal(result, expected) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("na_val, exp", [(lib.no_default, np.nan), (1, 1)]) | |||
| def test_to_numpy_null_array(na_val, exp): | |||
There was a problem hiding this comment.
Could you also test the dtype=None, na_value=lib.no_default case?
mroeschke
added
Dtype Conversions
mroeschke
approved these changes
Apr 5, 2023
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Apr 6, 2023
phofl
added a commit
to phofl/pandas
that referenced
this pull request
Apr 6, 2023
(cherry picked from commit 7974ad0)
mroeschke
added a commit
that referenced
this pull request
Apr 7, 2023
…o_numpy) (#52497) * BUG: segfault for null dtype in to_numpy (#52466) (cherry picked from commit 7974ad0) * Update pandas/core/arrays/arrow/array.py * Update pandas/core/arrays/arrow/array.py --------- Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.