Skip to content

REF: remove freq arg from PeriodArray constructor #52462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 7, 2023
Merged

REF: remove freq arg from PeriodArray constructor #52462

merged 6 commits into from
Apr 7, 2023

Conversation

jbrockmendel
Copy link
Member

Try to match the other constructors more closely

@mroeschke
Copy link
Member

Does this need to be deprecated since it's somewhat public? https://pandas.pydata.org/docs/reference/api/pandas.arrays.PeriodArray.html

@mroeschke mroeschke added the Period Period data type label Apr 6, 2023
@jbrockmendel
Copy link
Member Author

Does this need to be deprecated since it's somewhat public?

OK, will update

@jbrockmendel
Copy link
Member Author

updated as a deprecation + green

@mroeschke mroeschke added this to the 2.1 milestone Apr 7, 2023
@mroeschke mroeschke merged commit 9722fc9 into pandas-dev:main Apr 7, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-periodarray-freq branch April 7, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Period Period data type
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @mroeschke