REF: move methods from base to Index #52447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've merged #52428, so I think this should be rebased to avoid merge issues here. |
topper-123
added
Refactor
topper-123
reviewed
Apr 6, 2023
| @doc(NDFrame.isna, klass=_shared_doc_kwargs["klass"]) # type: ignore[has-type] | ||
| def isna(self) -> Series: # type: ignore[override] | ||
| def isna(self) -> Series: | ||
| return NDFrame.isna(self) |
There was a problem hiding this comment.
return super().isna()?
Same question below.
There was a problem hiding this comment.
avoiding super bc i always have to check which parent class it refers to
mroeschke
approved these changes
Apr 7, 2023
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.