GH-52093 : AttributeError raised with pd.concat between a None and Timestamp #52433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 6, 2023
mroeschke
reviewed
Apr 6, 2023
mroeschke
reviewed
Apr 6, 2023
| df = DataFrame(data) | ||
| data_2 = [{"A": pd.to_datetime("1990-12-20 00:00:00+00:00")}] | ||
| df_2 = DataFrame(data_2) | ||
| pd.concat([df, df_2]) |
There was a problem hiding this comment.
Suggested change
| pd.concat([df, df_2]) | |
| result = pd.concat([df, df_2]) |
And then construct the expected = DataFrame(...) result and then use tm.assert_frame_equal(result, expected)
mroeschke
reviewed
Apr 6, 2023
mroeschke
added
Missing-data
mroeschke
reviewed
Apr 7, 2023
mroeschke
reviewed
Apr 7, 2023
Co-authored-by: Matthew Roeschke <[email protected]>
mroeschke
reviewed
Apr 7, 2023
| df_2 = DataFrame(data_2) | ||
| result = concat([df, df_2]) | ||
| expected = DataFrame({"A": [pd.to_datetime("1990-12-20 00:00:00+00:00")]}) | ||
| tm.assert_frame_equal(result, expected) |
There was a problem hiding this comment.
Looks like this test is failing from the logs
There was a problem hiding this comment.
Actually can you please suggest a possible fix
There was a problem hiding this comment.
Check the result and make sure it has the same elements as expected
There was a problem hiding this comment.
Actually I tried, but it then says that there is a ValueError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.