Skip to content

PERF: avoid is_dtype_equal #52424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 1, 2023
Merged

Conversation

jbrockmendel
Copy link
Member

This gets rid of all our non-test usages.

@jbrockmendel
Copy link
Member Author

Will need to wait until we bump our minimum numpy version, not sure when exactly numpy fixed np.dtype.__eq__ to not raise

@jbrockmendel
Copy link
Member Author

mothballing to clear the queue

@jbrockmendel jbrockmendel added the Mothballed Temporarily-closed PR the author plans to return to label Apr 11, 2023
@jbrockmendel jbrockmendel reopened this Apr 28, 2023
@jbrockmendel jbrockmendel added Performance Memory or execution speed performance and removed Mothballed Temporarily-closed PR the author plans to return to labels Apr 28, 2023
@jbrockmendel
Copy link
Member Author

Looks like this is now viable since we've bumped our min numpy version

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. Just a merge conflict

@mroeschke mroeschke added this to the 2.1 milestone May 1, 2023
@mroeschke mroeschke merged commit 56537f4 into pandas-dev:main May 1, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the perf-is_dtype_equal branch May 1, 2023 23:58
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 7, 2023
* PERF: avoid is_dtype_equal

* PERF: avoid is_dtype_equal

* post-merge fixup
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
* PERF: avoid is_dtype_equal

* PERF: avoid is_dtype_equal

* post-merge fixup
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
* PERF: avoid is_dtype_equal

* PERF: avoid is_dtype_equal

* post-merge fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants