-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
PERF: avoid is_dtype_equal #52424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
PERF: avoid is_dtype_equal #52424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will need to wait until we bump our minimum numpy version, not sure when exactly numpy fixed |
mothballing to clear the queue |
Looks like this is now viable since we've bumped our min numpy version |
mroeschke
reviewed
May 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay. Just a merge conflict
mroeschke
approved these changes
May 1, 2023
Thanks @jbrockmendel |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 7, 2023
* PERF: avoid is_dtype_equal * PERF: avoid is_dtype_equal * post-merge fixup
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
* PERF: avoid is_dtype_equal * PERF: avoid is_dtype_equal * post-merge fixup
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* PERF: avoid is_dtype_equal * PERF: avoid is_dtype_equal * post-merge fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of all our non-test usages.