BUG: merge with arrow and numpy dtypes raises #52422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Reshaping
mroeschke
reviewed
Apr 5, 2023
pandas/core/reshape/merge.py
Outdated
| if not isinstance(lk, BaseMaskedArray): | ||
| if not isinstance(lk, BaseMaskedArray) and not ( | ||
| isinstance(lk.dtype, ArrowDtype) | ||
| and is_numeric_dtype(lk.dtype.numpy_dtype.type) |
There was a problem hiding this comment.
Suggested change
| and is_numeric_dtype(lk.dtype.numpy_dtype.type) | |
| and lk.dtype._is_numeric |
Might be simpler?
There was a problem hiding this comment.
doesn't work unfortunately, we have to exclude all arrow dtypes whose numpy dtype is object
mroeschke
reviewed
Apr 5, 2023
mroeschke
reviewed
Apr 5, 2023
5 tasks
Co-authored-by: Matthew Roeschke <[email protected]>
mroeschke
approved these changes
Apr 5, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Apr 6, 2023
phofl
added a commit
that referenced
this pull request
Apr 6, 2023
…types raises) (#52480) Backport PR #52422: BUG: merge with arrow and numpy dtypes raises Co-authored-by: Patrick Hoefler <[email protected]>
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This is similar to what we did for the Indexing engine