numpy ravel with dataframe test GH#26247 #52403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
liang3zy22
commented
Apr 4, 2023
liang3zy22
commented
- closes numpy ravel does not work on a list of DataFrames with specified column names #26247 (Replace xxxx with the GitHub issue number)
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
MarcoGorelli
suggested changes
Apr 4, 2023
There was a problem hiding this comment.
Thanks @liang3zy22 for your PR! this is off to a good start
I just have some comments:
- can we not use random numbers in the test please? let's use explicit input and output
- the test location might not be appropriate -
test_arrayis about the pandas array. How about pandas/tests/frame/test_npfuncs.py? - not too keen on single-letter variable names, we can use
arrplease to construct a numpy array?
pandas/tests/arrays/test_array.py
Outdated
|
|
||
| def test_array_ravel_from_df(): | ||
| # GH26247 | ||
| x = np.random.randn(10, 3) |
There was a problem hiding this comment.
can we not use random numbers in a test (unless necessary) please? let's contruct both the input and the output explicitly
so
arr = np.array([...])
pandas/tests/arrays/test_array.py
Outdated
| x = np.random.randn(10, 3) | ||
|
|
||
| result = np.ravel([pd.DataFrame(batch.reshape(1, 3)) for batch in x]) | ||
| expected = np.ravel(x) |
There was a problem hiding this comment.
likewise, let's construct the output explicitly
MarcoGorelli
added
Needs Tests
MarcoGorelli
suggested changes
Apr 5, 2023
Signed-off-by: Liang Yan <[email protected]>
MarcoGorelli
approved these changes
Apr 5, 2023
mroeschke
approved these changes
Apr 6, 2023
|
Thanks @liang3zy22 |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Apr 6, 2023
Signed-off-by: Liang Yan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.