Add a test for agg std #52371
Add a test for agg std #52371
Conversation
| @@ -1577,3 +1577,9 @@ def test_agg_groupings_selection(): | |||
| ) | |||
| expected = DataFrame({"b": [6, 4], "c": [11, 7]}, index=index) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| def test_agg_std(): | |||
| df = pd.DataFrame({'A': [1, 2, 3], 'B': [4, 5, 6]}) | |||
There was a problem hiding this comment.
Can you use the exact DataFrame from the issue?
|
|
||
| def test_agg_std(): | ||
| df = pd.DataFrame({'A': [1, 2, 3], 'B': [4, 5, 6]}) | ||
| std = df.agg(np.std) |
There was a problem hiding this comment.
| std = df.agg(np.std) | |
| expected = df.agg(np.std) |
Could you also compare df.agg([np.std])?
There was a problem hiding this comment.
Hello @mroeschke, I'm sorry but I'm not sure what you are asking. Do you want me to check the type of class? e.g (pandas.core.series.Series)
There was a problem hiding this comment.
Just asking to add a test to also check the result of df.agg([np.std]) as well
| df = pd.DataFrame({'A': [1, 2, 3], 'B': [4, 5, 6]}) | ||
| std = df.agg(np.std) | ||
| expected = pd.Series({'A': 1.0, 'B': 1.0}, dtype=float) | ||
| assert std.equals(expected) |
There was a problem hiding this comment.
| assert std.equals(expected) | |
| tm.assert_series_equal(result, expected) |
|
Can you move the test to |
mroeschke
added
Testing
|
I believe that this will fulfill your request, but please let me know if there is anything else I can do. @mroeschke |
| tm.assert_series_equal(result, expected) | ||
|
|
||
| result = df.agg([np.std]) | ||
| assert isinstance(result, pd.DataFrame) |
There was a problem hiding this comment.
Please construct the expected result and use tm.assert_frame_equal
|
Looks like a few of the code check builds are failing |
|
@mroeschke , I have fixed the code checks that were failing, and I have constructed the tests as your instructions. |
|
Awesome! Thanks @steliospetrakis02 |
You're welcome! I thank you for your guidance and assistance as I take my first steps into contributing to pandas |
* Add a test for agg std * move the test as requested and added one more test for df.agg([np.std]) * fix second test * fix format * Update test_aggregate.py * Update test_frame_apply.py
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.I believe that this test ensures the expected output. Let me know if you have any questions or concerns.