DOC: cleanup whatsnew entry for na_action='ignore' #52355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mroeschke
reviewed
Apr 3, 2023
mroeschke
reviewed
Apr 3, 2023
mroeschke
reviewed
Apr 3, 2023
mroeschke
reviewed
Apr 3, 2023
mroeschke
reviewed
Apr 3, 2023
|
|
||
| Frequently, it is not desirable to apply the callable to nan-like values of the array and to avoid doing | ||
| that, the ``map`` method could be called with ``na_action="ignore"``, e.g. like this: ``ser.map(func, na_action="ignore")``. | ||
| However, ``na_action="ignore"`` was not implemented for many ``ExtensionArray`` and ``Index`` types |
There was a problem hiding this comment.
Could you note specifically which types
na_actionis now consistently respected? (the datetime likes and period)?
I made a new version. I think its difficult to explain what didn't work correctly succintly. There were some patterns that worked correctly, other failed, while other gave a wrong result for the same ExtensionArray (e.g. the Categorical example below).
In short, .map could behave very erratic 😄.
Co-authored-by: Matthew Roeschke <[email protected]>
Co-authored-by: Matthew Roeschke <[email protected]>
Co-authored-by: Matthew Roeschke <[email protected]>
Co-authored-by: Matthew Roeschke <[email protected]>
|
I’ve updated. |
mroeschke
approved these changes
Apr 4, 2023
|
Thanks @topper-123 |
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
Apr 6, 2023
* DOC: cleanup whatsnew entry for na_action='ignore' * Update doc/source/whatsnew/v2.1.0.rst Co-authored-by: Matthew Roeschke <[email protected]> * Update doc/source/whatsnew/v2.1.0.rst Co-authored-by: Matthew Roeschke <[email protected]> * Update doc/source/whatsnew/v2.1.0.rst Co-authored-by: Matthew Roeschke <[email protected]> * Update doc/source/whatsnew/v2.1.0.rst Co-authored-by: Matthew Roeschke <[email protected]> * update comment --------- Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.