Skip to content

DOC streamline contributing guide a bit #52328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MarcoGorelli
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Some relatively minor things I noticed

@MarcoGorelli MarcoGorelli requested a review from noatamir March 31, 2023 17:01
@MarcoGorelli MarcoGorelli force-pushed the trim-down-contributing-guide branch from c613f01 to 55ea07e Compare March 31, 2023 17:02
@mroeschke mroeschke added the Docs label Mar 31, 2023
@mroeschke
Copy link
Member

2023-03-31T17:15:59.3514670Z /home/runner/work/pandas/pandas/doc/source/development/contributing_codebase.rst:38: ERROR: Unexpected indentation.
2023-03-31T17:15:59.3517430Z /home/runner/work/pandas/pandas/doc/source/development/contributing_codebase.rst:41: WARNING: Block quote ends without a blank line; unexpected unindent.

@MarcoGorelli MarcoGorelli marked this pull request as draft April 3, 2023 19:21
@MarcoGorelli MarcoGorelli marked this pull request as ready for review April 5, 2023 11:05
@mroeschke mroeschke added this to the 2.1 milestone Apr 6, 2023
@mroeschke mroeschke merged commit 0e39016 into pandas-dev:main Apr 6, 2023
@mroeschke
Copy link
Member

Thanks @MarcoGorelli

topper-123 pushed a commit to topper-123/pandas that referenced this pull request Apr 6, 2023
* streamline contributing guide a bit

* fixup sphinx error

---------

Co-authored-by: MarcoGorelli <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants