DOC: Clarify Timestamp(unit=) will not necessarily set unit #52311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Docs
Non-Nano
pandas/_libs/tslibs/timestamps.pyx
Outdated
| @@ -1293,6 +1293,9 @@ class Timestamp(_Timestamp): | |||
| Unit used for conversion if ts_input is of type int or float. The | |||
| valid values are 'D', 'h', 'm', 's', 'ms', 'us', and 'ns'. For | |||
| example, 's' means seconds and 'ms' means milliseconds. | |||
|
|
|||
| The result will be stored in nanoseconds, and the unit attribute | |||
| will be set as ``'ns'``. | |||
There was a problem hiding this comment.
this is only the case for floats. for ints we do keep the unit where possible
There was a problem hiding this comment.
I noticed this as well (haven't checked to see if its expected):
import pandas as pd
unit = "s"
ts1 = pd.to_datetime(1, unit=unit)
ts2 = pd.Timestamp(1, unit=unit)
print(f"{ts1.unit=}, {ts2.unit=}")
td1 = pd.to_timedelta(1, unit=unit)
td2 = pd.Timedelta(1, unit=unit)
print(f"{td1.unit=}, {td2.unit=}")
output:
ts1.unit='ns', ts2.unit='s'
td1.unit='ns', td2.unit='ns'
There was a problem hiding this comment.
Thanks, clarified that it's only for floats
phofl
approved these changes
Apr 2, 2023
|
thx @mroeschke |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Apr 2, 2023
…necessarily set unit
phofl
pushed a commit
that referenced
this pull request
Apr 2, 2023
…l not necessarily set unit) (#52360) Backport PR #52311: DOC: Clarify Timestamp(unit=) will not necessarily set unit Co-authored-by: Matthew Roeschke <[email protected]>
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pd.TimeStamp&pd.Timedeltanot always adhering tounitparameter inpandas-2.0#52286 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.