Skip to content

combine_first with mix tz test GH#26283 #52294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2023
Merged

combine_first with mix tz test GH#26283 #52294

merged 1 commit into from
Mar 30, 2023

Conversation

liang3zy22
Copy link
Contributor

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Timezones Timezone data dtype labels Mar 30, 2023
@mroeschke mroeschke added this to the 2.1 milestone Mar 30, 2023
@mroeschke mroeschke merged commit 261d425 into pandas-dev:main Mar 30, 2023
@mroeschke
Copy link
Member

Thanks @liang3zy22

@liang3zy22 liang3zy22 deleted the gh26283 branch March 31, 2023 00:03
topper-123 pushed a commit to topper-123/pandas that referenced this pull request Apr 1, 2023
@liang3zy22 @topper-123
combine_first with mix tz test GH#26283 (pandas-dev#52294)
6e192ad 
Signed-off-by: Liang Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite Timezones Timezone data dtype
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

BUG: Series.combine_first raises ValueError on mixed-timezone datetime-index
2 participants
@liang3zy22 @mroeschke