PERF: needs_i8_conversion expect dtype object #52288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Mar 30, 2023
| True | ||
| >>> needs_i8_conversion(np.array(['a', 'b'])) | ||
| False | ||
| >>> needs_i8_conversion(pd.Series([1, 2])) | ||
| False | ||
| >>> needs_i8_conversion(pd.Series([], dtype="timedelta64[ns]")) | ||
| True | ||
| False |
There was a problem hiding this comment.
I guess this didn't meaningfully affect existing usage, or was this always supposed to be false?
There was a problem hiding this comment.
The existing implementation, like the is_foo_dtype functions, will unwrap array-likes. We've changed most of our usages to not need that. This just enforces that (which is why we don't really get a perf bump)
mroeschke
approved these changes
Mar 30, 2023
|
Thanks @jbrockmendel |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Apr 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.