Skip to content

BUG #52197 proposed fix #52251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2023
Merged

BUG #52197 proposed fix #52251

merged 3 commits into from
Mar 28, 2023

Conversation

zbreger
Copy link
Contributor

@zbreger zbreger commented Mar 27, 2023

zbreger added 3 commits March 27, 2023 18:45
@zbreger
pandas-dev#52197 bug fix. These styling details aren't intended to be…
be2809e 
… in the DataFrame. When these style elements are encountered upon parsing, the trees rooted in these elements are dropped.
@zbreger
Removing extraneous line used for testing
73ca1b8
@zbreger
Added an entry in the latest doc file
de603d8
@topper-123 topper-123 added Bug IO HTML read_html, to_html, Styler.apply, Styler.applymap labels Mar 28, 2023
@topper-123 topper-123 added this to the 2.1 milestone Mar 28, 2023
topper-123
topper-123 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look good to me, but I've worked very little with styles and xpath styles, so I'll approve and let someone else take a look too.

@mroeschke mroeschke merged commit 2ca9b3c into pandas-dev:main Mar 28, 2023
@mroeschke
Copy link
Member

Thanks @zbreger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@topper-123 topper-123 topper-123 approved these changes

Assignees
No one assigned
Labels
Bug IO HTML read_html, to_html, Styler.apply, Styler.applymap
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

BUG: read_html reads <style> element text
3 participants
@zbreger @mroeschke @topper-123