Skip to content

TYP: remove mypy ignore from array_manager.py #52249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 29, 2023
Merged

TYP: remove mypy ignore from array_manager.py #52249

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4a9bcb6
TYP: remove ignore from array_manager.py
natmokval Mar 27, 2023
90a5972
Merge branch 'main' into 37715-remove-mypy-ignore
natmokval Mar 27, 2023
ca58222
Merge branch 'main' into 37715-remove-mypy-ignore
natmokval Mar 28, 2023
31287f0
TYP: remove ignore from array_manager.py II
natmokval Mar 28, 2023
c861a74
TYP: remove ignore from array_manager.py III
natmokval Mar 29, 2023
73c4ad7
Merge branch 'main' into 37715-remove-mypy-ignore
natmokval Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions pandas/core/internals/array_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,17 +834,15 @@ def iset(

# multiple columns -> convert slice or array to integer indices
elif isinstance(loc, slice):
indices = range(
indices: range | np.ndarray = range(
loc.start if loc.start is not None else 0,
loc.stop if loc.stop is not None else self.shape_proper[1],
loc.step if loc.step is not None else 1,
)
else:
assert isinstance(loc, np.ndarray)
assert loc.dtype == "bool"
# error: Incompatible types in assignment (expression has type "ndarray",
# variable has type "range")
indices = np.nonzero(loc)[0] # type: ignore[assignment]
indices = np.nonzero(loc)[0]

assert value.ndim == 2
assert value.shape[0] == len(self._axes[0])
Expand Down