CI: Try running single_cpu/not single_cpu tests together #52239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't quite work yet (need to figure out how to propagate the PATTERN variable). |
mroeschke
reviewed
Mar 27, 2023
|
I would recommend bumping up the |
It's already 3 hours which should be fine (all tests seem to take about 1ish hour). |
mroeschke
reviewed
Mar 28, 2023
|
Looks like on the latest commit that the single cpu task isn't running |
mroeschke
approved these changes
Mar 30, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Mar 30, 2023
…pu tests together
|
Nice cleanup! Thanks @lithomas1. Hoping to follow up with #52211 to reduce the number of queued workflows even further |
mroeschke
pushed a commit
that referenced
this pull request
Mar 30, 2023
…ngle_cpu tests together) (#52292) Backport PR #52239: CI: Try running single_cpu/not single_cpu tests together Co-authored-by: Thomas Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.If I did this right, should get us from 20 jobs to around 14 jobs.
This'll probably slow down the current jobs by ~10 minutes (but they already take 1 hr), but we'll save at least the 5 minutes of compiling pandas on the single_cpu jobs + whatever it takes to setup the conda envs there.
Hopefully the shorter queue times during peak periods makes up for the extra time.