Skip to content

COMPAT: Remove unnecessary memoryview workaround #52237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 18, 2023
Merged

COMPAT: Remove unnecessary memoryview workaround #52237

merged 4 commits into from
Jul 18, 2023

Conversation

lithomas1
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@lithomas1 lithomas1 added the Compat pandas objects compatability with Numpy or Python functions label Mar 27, 2023
@lithomas1 lithomas1 added this to the 2.0 milestone Mar 27, 2023
@lithomas1 lithomas1 removed this from the 2.0 milestone Mar 27, 2023
@lithomas1 lithomas1 added the Mothballed Temporarily-closed PR the author plans to return to label Mar 27, 2023
@lithomas1 lithomas1 closed this Mar 27, 2023
@lithomas1 lithomas1 reopened this Jul 17, 2023
@lithomas1 lithomas1 changed the title COMPAT: Update code for Cython 3.0b2 COMPAT: Update code for Cython 3.0 Jul 17, 2023
@lithomas1 lithomas1 marked this pull request as ready for review July 17, 2023 21:34
@lithomas1 lithomas1 requested a review from WillAyd as a code owner July 17, 2023 21:34
@lithomas1 lithomas1 removed the Mothballed Temporarily-closed PR the author plans to return to label Jul 17, 2023
@lithomas1 lithomas1 added this to the 2.1 milestone Jul 17, 2023
@lithomas1
Copy link
Member Author

I think Cython patched the memoryview bug now.

Probably safer to hold off merging for now until CI gets back to green.

@lithomas1 lithomas1 changed the title COMPAT: Update code for Cython 3.0 COMPAT: Remove unnecessary memoryview workaround Jul 17, 2023
@mroeschke
Copy link
Member

Looks good. Could you merge in main once more?

@mroeschke mroeschke merged commit 3a2ec64 into pandas-dev:main Jul 18, 2023
@mroeschke
Copy link
Member

Thanks @lithomas1

@lithomas1 lithomas1 deleted the bump-cython3 branch July 18, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@WillAyd WillAyd Awaiting requested review from WillAyd

Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@lithomas1 @mroeschke