BUG: Removed bug from groupby/min on categoricals #52236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for the fixed bug |
|
Yes but where? |
|
either of those would be fine, i guess the min_max one would be my preference. |
|
@jbrockmendel I added the test. I think that the failings are not related with what I did, but I'm not sure. |
|
Could you merge the main branch once more? |
|
Done. |
mroeschke
approved these changes
Mar 30, 2023
|
Thanks @DeaMariaLeon |
|
Thank you |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Apr 1, 2023
* removed bug WrappedCythonOp * added test * added functions to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
groupby/minandobserved=Falseon categoricals between 2.0 and 2.1 #52151 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.