Skip to content

CI: replace flake8-pyi with ruff #52226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2023
Merged

CI: replace flake8-pyi with ruff #52226

merged 1 commit into from
Mar 26, 2023

Conversation

twoertwein
Copy link
Member

Not all rules are covered by ruff but, from my point of view, the important ones are covered.

@MarcoGorelli MarcoGorelli added this to the 2.1 milestone Mar 26, 2023
@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Mar 26, 2023
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @twoertwein !

@MarcoGorelli MarcoGorelli merged commit 5c4cc4a into pandas-dev:main Mar 26, 2023
@twoertwein
Copy link
Member Author

Slightly (un)-related: Ruff started to cover some of the autotyping parts. I would be fine replacing autotyping with ruff when ruff adds type annotations to int/float/str/... default parameters. I consider this rule "important" as it "gently encourages" people who add new arguments to also add type annotations.

@MarcoGorelli
Copy link
Member

sounds good

did you try upgrading to the latest autotyping? I tried, but got lots of error I couldn't resolve (though admittedly I didn't spend that long on it)

@twoertwein
Copy link
Member Author

did you try upgrading to the latest autotyping? I tried, but got lots of error I couldn't resolve (though admittedly I didn't spend that long on it)

I think these are triggered by the new --guess-common-names. I will go through them and see which ones are correct. But I think we probably have to exclude that option (or postpone until all incorrect guesses have correct annotations) .

@twoertwein twoertwein deleted the pyi branch August 9, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants