-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI: Test pyarrow nightly instead of intermediate versions #52211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 15 commits
87d6e86
7703e6a
531fb29
9b8cdb5
d195e1c
db122cf
63bb9df
22f97d2
8083dd3
5e2fdb1
906c221
aafc760
509bd07
00757ef
592cfe7
47d54e6
460da08
b517332
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
name: pandas-dev | ||
channels: | ||
- conda-forge | ||
dependencies: | ||
- python=3.11 | ||
|
||
# build dependencies | ||
- versioneer[toml] | ||
- cython>=0.29.33 | ||
|
||
# test dependencies | ||
- pytest>=7.0.0 | ||
- pytest-cov | ||
- pytest-xdist>=2.2.0 | ||
- hypothesis>=6.34.2 | ||
- pytest-asyncio>=0.17.0 | ||
- boto3 | ||
|
||
# required dependencies | ||
- python-dateutil | ||
- numpy | ||
- pytz | ||
- pip | ||
|
||
- pip: | ||
- "tzdata>=2022.1" | ||
- "--extra-index-url https://pypi.fury.io/arrow-nightlies/" | ||
- "--prefer-binary" | ||
- "--pre" | ||
- "pyarrow" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,22 +92,18 @@ def _get_path_or_handle( | |
if fs is not None: | ||
pa_fs = import_optional_dependency("pyarrow.fs", errors="ignore") | ||
fsspec = import_optional_dependency("fsspec", errors="ignore") | ||
if pa_fs is None and fsspec is None: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did this change There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The build dependency setup uncovered a bug in the recent pyarrow Filesystem implementation not raising a |
||
raise ValueError( | ||
f"filesystem must be a pyarrow or fsspec FileSystem, " | ||
f"not a {type(fs).__name__}" | ||
) | ||
elif (pa_fs is not None and not isinstance(fs, pa_fs.FileSystem)) and ( | ||
fsspec is not None and not isinstance(fs, fsspec.spec.AbstractFileSystem) | ||
): | ||
if pa_fs is not None and isinstance(fs, pa_fs.FileSystem): | ||
if storage_options: | ||
raise NotImplementedError( | ||
"storage_options not supported with a pyarrow FileSystem." | ||
) | ||
elif fsspec is not None and isinstance(fs, fsspec.spec.AbstractFileSystem): | ||
pass | ||
else: | ||
raise ValueError( | ||
f"filesystem must be a pyarrow or fsspec FileSystem, " | ||
f"not a {type(fs).__name__}" | ||
) | ||
elif pa_fs is not None and isinstance(fs, pa_fs.FileSystem) and storage_options: | ||
raise NotImplementedError( | ||
"storage_options not supported with a pyarrow FileSystem." | ||
) | ||
if is_fsspec_url(path_or_handle) and fs is None: | ||
if storage_options is None: | ||
pa = import_optional_dependency("pyarrow") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is boto3 a required dep for pyarrow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think so. I think i accidentally copied this from another deps file