-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC warn user about potential information loss in Resampler.interpolate #52198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC warn user about potential information loss in Resampler.interpolate #52198
Conversation
Thanks, looks like some of our docstring validations are failing |
@@ -825,7 +825,6 @@ def fillna(self, method, limit: int | None = None): | |||
""" | |||
return self._upsample(method, limit=limit) | |||
|
|||
@doc(NDFrame.interpolate, **_shared_docs_kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mroeschke here I removed the docstring concatenation (this is misleading, since the user probably has no NaNs in its data originally) and added links to documentation, so the user can inform her/himself about various methods
@mroeschke let me know if something is missing/to be extended |
Thanks @kopytjuk |
In scientific and technical domain people deal with high-frequent or non-equidistant timeseries. Using
resample("1s").interpolate()
can have unwanted side effects which we should warn in the documentation:which leads to the following:
For that example, information loss is expected.
Imho we should warn the user about this behavior. It seems to be known, to quote @jreback from here:
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.