-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Clarify difference between StringDtype(pyarrow) and ArrowDtype(string) #52184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wording looks good
|
||
.. ipython:: python | ||
|
||
data = list("abc") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a pyarrow import
@@ -115,7 +131,7 @@ The following are just some examples of operations that are accelerated by nativ | |||
ser.isna() | |||
ser.fillna(0) | |||
|
|||
ser_str = pd.Series(["a", "b", None], dtype="string[pyarrow]") | |||
ser_str = pd.Series(["a", "b", None], dtype=pd.ArrowDtype(pa.string())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here probably
Is there a plan to deprecate the older one and if so should that be mentioned here? |
thx @mroeschke There is a discussion about deprecating this somewhere but no consensus yet. |
…type(pyarrow) and ArrowDtype(string)
…tringDtype(pyarrow) and ArrowDtype(string)) (#52192) Backport PR #52184: DOC: Clarify difference between StringDtype(pyarrow) and ArrowDtype(string) Co-authored-by: Matthew Roeschke <[email protected]>
Yeah the discussion started at #48469 |
Spawned from a discussion in #52156