Skip to content

DOC: Clarify difference between StringDtype(pyarrow) and ArrowDtype(string) #52184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2023

Conversation

mroeschke
Copy link
Member

Spawned from a discussion in #52156

@mroeschke mroeschke added Docs Arrow pyarrow functionality labels Mar 24, 2023
@mroeschke mroeschke added this to the 2.0 milestone Mar 24, 2023
@mroeschke mroeschke requested a review from phofl March 24, 2023 21:23
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wording looks good


.. ipython:: python

data = list("abc")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a pyarrow import

@@ -115,7 +131,7 @@ The following are just some examples of operations that are accelerated by nativ
ser.isna()
ser.fillna(0)

ser_str = pd.Series(["a", "b", None], dtype="string[pyarrow]")
ser_str = pd.Series(["a", "b", None], dtype=pd.ArrowDtype(pa.string()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here probably

@jbrockmendel
Copy link
Member

Is there a plan to deprecate the older one and if so should that be mentioned here?

@phofl phofl merged commit b63d35d into pandas-dev:main Mar 25, 2023
@phofl
Copy link
Member

phofl commented Mar 25, 2023

thx @mroeschke

There is a discussion about deprecating this somewhere but no consensus yet.

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 25, 2023
phofl pushed a commit that referenced this pull request Mar 25, 2023
…tringDtype(pyarrow) and ArrowDtype(string)) (#52192)

Backport PR #52184: DOC: Clarify difference between StringDtype(pyarrow) and ArrowDtype(string)

Co-authored-by: Matthew Roeschke <[email protected]>
@mroeschke
Copy link
Member Author

Yeah the discussion started at #48469

@mroeschke mroeschke deleted the doc/string_arrow_diff branch March 25, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants