PERF: avoid exceptions in string.Construction benchmark setup #52176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#37371 added some new benchmarks, along with some new setup code for the new benchmarks. Unfortunately, the new setup code introduced an uncaught exception:
This caused asv to skip all the string construction benchmarks since that PR was merged because the setup had an uncaught exception. See e.g. this benchmark report.
The fix is just to remove the broken benchmarks.
I built a version of pandas from just after #37371 was merged and verified that the benchmark was broken then. I can't easily verify that the benchmark has been broken the entire time since then but I strongly suspect that's the case.