-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: update examples in MonthBegin/MonthEnd to use rollbackward/rollforward #52161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: update examples in MonthBegin/MonthEnd to use rollbackward/rollforward #52161
Conversation
- updated docstrings of pandas.offsers.MonthBegin, MonthEnd, BMonthBegin, BMonthEnd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great first contribution, thanks @pranav-ravuri ! Looks good to me pending green
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
@pranav-ravuri there's one more related one, in case you wanted to take this one on #52169 |
Hi @MarcoGorelli there seems to be conflict, but I did not understand what it is? And how could I have avoided it? |
the conflict is only when backporting to version 2.0 (from which the next stable docs will be built) - you did everything right, it's just that not everything gets backported, so conflicts creep in sometimes |
Backport PR #52161: Docs/update issue 52106 Co-authored-by: Pranav Saibhushan Ravuri <[email protected]>
updated docstring of pandas.offsets.MonthBegin, pandas.offsets.MonthEnd, pandas.offsets.BMonthBegin, pandas.offsets.BMonthEnd
the output of the
validate_docsctrings.py
is similar to the below output as follows