DOC update contributors

[MarcoGorelli]

In the Slack channel, a contributor has been requested to be renamed due to having changed their legal name

I think it's a reasonable request, we can just add a mapping within announce.py to map the old name to the new one (I've just encoded them to avoid hard-coding someone's name in a file)

[jreback]

even though this is easy i don't think it should be done

history is history and we should be changing it

[MarcoGorelli]

In general I agree, but for context, this is someone who changed their name after coming out - I think we should allow it

Github already displays the new name

No need to change the commits themselves, but just displaying a new name in the release notes sounds fine

[jorisvandenbossche]

Thanks @MarcoGorelli !
I think this is an easy and elegant solution

history is history and we should be changing it

We are not changing any git history or historical docs. We are just updating future docs to use a new name in our own generated list of contributors.

[rhshadrach]

Once you change from one GitHub username to another, is your previous username available for the taking by others? If that's the case, then I'm -1 here.

Otherwise I'm +0 here. I don't think we have an obligation to update prior whatsnew (even if they are being built in the future), and this would be a bit of an annoyance if it were widely used (I don't expect it will be). At the same time, I can see the desire from a contributor's standpoint and the implementation is simple enough.

[jorisvandenbossche]

Once you change from one GitHub username to another, is your previous username available for the taking by others? If that's the case, then I'm -1 here.

AFAIK this is not actually related to GitHub usernames. It is the name you use in your git commit, and that's just a local git config setting at the time of making the commit, that then is embodied in the commit author details.
I can perfectly set up my git config to use any other name that could clash with other people's name or github username.

[rhshadrach]

Ah, that's right, thanks. While that makes me a bit wary here, I'm +0.

[MarcoGorelli]

looks like this is somewhat controversial...removing from the 2.0 milestone for now, let's not rush it

[MarcoGorelli]

merging as per today's discussion