DOC: ddof in cov when nans present #52137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is my first time OSS contributing. |
|
Hey @whooolemilk Thanks for picking this up! In general, how to work with errors (there will be many) is to look into the test logs and find the relevant log line. In this case try to look into the |
|
To avoid the rst check issue you could just reword the sentence, for example |
|
Looks good. Thanks @whooolemilk. |
|
@topper-123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ddofincovwhennans present #47042doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This PR adds a document about the "
nans must not be present in the dataframe" restriction on ddof in pandas.DataFrame.cov.