-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REF: implement NDFrame._from_mgr #52132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
de51d2c
REF: implement NDFrame._from_mgr
jbrockmendel f5dbd91
Merge branch 'main' into ref-from_mgr
jbrockmendel 9815154
mypy fixup
jbrockmendel 714bae7
short-term alias
jbrockmendel 77c4a1d
Merge branch 'main' into ref-from_mgr
jbrockmendel 4b29645
Merge branch 'main' into ref-from_mgr
jbrockmendel c0aac8b
Merge branch 'main' into ref-from_mgr
jbrockmendel da22ff2
Merge branch 'main' into ref-from_mgr
jbrockmendel 15019a5
Merge branch 'main' into ref-from_mgr
jbrockmendel 3ca1ae4
Merge branch 'main' into ref-from_mgr
jbrockmendel 38e5759
REF: implement _constructor_from_mgr
jbrockmendel a89edb2
Merge branch 'main' into ref-from_mgr
jbrockmendel 78790e5
update _sliced_from_mgr
jbrockmendel 191a08a
mypy fixup
jbrockmendel 7aba6b5
Merge branch 'main' into ref-from_mgr
jbrockmendel 132894c
Merge branch 'main' into ref-from_mgr
jbrockmendel 68bb080
Merge branch 'main' into ref-from_mgr
jbrockmendel 8b0e785
Merge branch 'main' into ref-from_mgr
jbrockmendel a125080
Merge branch 'main' into ref-from_mgr
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this assert needed here? (it's also not done in
_from_mgr
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly. ATM _from_mgr is documented as requiring them to match, so this assertion seemed like an easy way of making it required along this path too. could remove the assertion and document the requirement in the docstring