Skip to content

ENH: Add usecols option to python parser. #5211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2013

Conversation

guyrt
Copy link
Contributor

@guyrt guyrt commented Oct 13, 2013

Closes #4335

This ticket felt a little bit like whack-a-mole.

The key is that names can have two meanings: if it matches length of usecols then it is the name to apply to the (numeric) usecols. If it matches the length of the original columns, it is the set of column names and string values in usecols refer to it.

@jreback
Copy link
Contributor

jreback commented Oct 13, 2013

pls also add a release notes entry and update io.rst docs (e.g. the default for the header is now slightly different as you changed in the doc string?)

@jreback
Copy link
Contributor

jreback commented Oct 13, 2013

for py3, use compat.string_types instead of basestring (you may also need to import it)

@guyrt
Copy link
Contributor Author

guyrt commented Oct 15, 2013

I added release notes. @jreback do we have to update the io.rst docs manually or is that generated?

FWIW my docstring update reflects pre-existing behaviour. I just made it explicit.

@jreback
Copy link
Contributor

jreback commented Oct 15, 2013

@guyrt you can edit io.rst (or any other doc file) just like code....edit and it will be included in the commit
the docs themselves are generated from that...(which you can build to look at locally if you would like).

@jreback
Copy link
Contributor

jreback commented Oct 16, 2013

can you rebase and squash?

- DataFrame has a new ``interpolate`` method, similar to Series (:issue:`4434`, :issue:`1892`)


- ``tz_localize`` can infer a fall daylight savings transition based on the structure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did these come from? (aside from this issue reference)

@guyrt
Copy link
Contributor Author

guyrt commented Oct 16, 2013

Looks like I goofed on the rebase.

edit: fixed

Closes pandas-dev#4335

Added release note and fixed py3 compat

Updated docs for consistency
@jreback
Copy link
Contributor

jreback commented Oct 17, 2013

merge this? (as its separate from #5156) ?

@guyrt
Copy link
Contributor Author

guyrt commented Oct 17, 2013

This one is ready to merge. #5156 will be a separate PR

jreback added a commit that referenced this pull request Oct 17, 2013
ENH: Add usecols option to python parser.
@jreback jreback merged commit d0438a2 into pandas-dev:master Oct 17, 2013
- Added PySide support for the qtpandas DataFrameModel and DataFrameWidget.

- Python csv parser now supports usecols (:issue:`4335`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you throw this into release notes as well (on your next PR)? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH/BUG: pd.read_csv(): usecols does not work when also using skipfooter
2 participants