Skip to content

API CoW: Return read_only NumPy array from ravel #52060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Mar 17, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

cc @jorisvandenbossche thoughts here?

@phofl phofl added this to the 2.0 milestone Mar 17, 2023
@phofl
Copy link
Member Author

phofl commented Mar 29, 2023

I'll merge this since it should really make it into 2.0

@phofl phofl merged commit 81fea58 into pandas-dev:main Mar 29, 2023
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 29, 2023
phofl added a commit that referenced this pull request Mar 29, 2023
…rray from ravel) (#52273)

Backport PR #52060: API CoW: Return read_only NumPy array from ravel

Co-authored-by: Patrick Hoefler <[email protected]>
@jorisvandenbossche
Copy link
Member

Sorry for letting this slip through, thanks for merging!

thoughts here?

My thought is that we should deprecate ravel(), but yes as long as we have it, it should behave similarly as the other methods that give a numpy array.

@phofl phofl deleted the cow_ravel_read_only branch April 27, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants