REF: uses_mask in group_any_all #52043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Mar 17, 2023
| # Set the position as masked if `out[lab] != flag_val`, which | ||
| # would indicate True/False has not yet been seen for any/all, | ||
| # so by Kleene logic the result is currently unknown | ||
| if out[lab, j] != flag_val: | ||
| out[lab, j] = -1 | ||
| result_mask[lab, j] = 1 |
There was a problem hiding this comment.
For any: If NA is encountered as first value in the group you are setting the mask to 1 here but you don't reset it if you find another value in the group that is not NA. You'll have to update the result_mask if you find another value.
There was a problem hiding this comment.
Oh OK. I missed that we are checking out[lab, j] != ... here as opposed to values[i, j] != .... Thanks.
phofl
reviewed
Mar 17, 2023
| pp_kwargs["result_mask"] = result_mask | ||
|
|
||
| result = post_processing(result, inferences, **pp_kwargs) | ||
| result = post_processing(result, inferences, result_mask=result_mask) |
There was a problem hiding this comment.
You'll probably have to remove the flag is_nullable for the std post_processing function (the default is False) and check for result_mask is not None
phofl
reviewed
Mar 17, 2023
|
Your suggestion helped, green |
phofl
approved these changes
Mar 17, 2023
|
thx @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
any, all, and std go through GroupBy._get_cythonized_result instead of the more-standard WrappedCythonOp. I'm trying to refactor any/all to use the other path, and as a step toward that am trying to make group_any_all follow the same patterns as the other functions in libgroupby.
The implementation here looks to me like it should behave identically to the existing implementation, but it fails a bunch of tests (mostly in tests/groupby/test_any_all.py). Hoping @phofl can explain where I'm going wrong.