BUG-CoW: DataFrame constructed from Series not respecting CoW #52031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
approved these changes
Mar 17, 2023
| @@ -291,7 +293,20 @@ def ndarray_to_mgr( | |||
| if values.ndim == 1: | |||
| values = values.reshape(-1, 1) | |||
|
|
|||
| elif isinstance(values, (np.ndarray, ExtensionArray, ABCSeries, Index)): | |||
| elif isinstance(values, ABCSeries): | |||
There was a problem hiding this comment.
Should this path handle both Series and Index?
There was a problem hiding this comment.
Ah, I see you indicated to do that in a follow-up (although I would assume it's "just" adding Index to this check?)
There was a problem hiding this comment.
Yeah I think so, but would mean adding more tests and increasing the diff. Separate would probably keep it a bit simpler
|
|
||
| def test_dataframe_from_series_infer_datetime(using_copy_on_write): | ||
| ser = Series([Timestamp("2019-12-31"), Timestamp("2020-12-31")], dtype=object) | ||
| df = DataFrame(ser) |
There was a problem hiding this comment.
We should stop inferring this, but that's another issue ;)
# Conflicts: # doc/source/whatsnew/v2.0.0.rst # pandas/tests/copy_view/test_constructors.py
|
I'll merge this to get it into 2.0 and to make the follow up |
phofl
added a commit
that referenced
this pull request
Mar 29, 2023
…om Series not respecting CoW) (#52274) Backport PR #52031: BUG-CoW: DataFrame constructed from Series not respecting CoW Co-authored-by: Patrick Hoefler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.right now we back the DataFrame by a read-only array, before the read-only pr this did not respect CoW.
Follow-up will be to do the same for Index.