Skip to content

BUG-CoW: from_records not tracking references when called with df #52029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2023
Merged

BUG-CoW: from_records not tracking references when called with df #52029

merged 3 commits into from
Mar 17, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Mar 16, 2023 •
edited
Loading

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added DataFrame DataFrame data structure Copy / view semantics labels Mar 16, 2023
@phofl phofl added this to the 2.0 milestone Mar 16, 2023
@jorisvandenbossche
Copy link
Member

(has some conflicts now)

@phofl
Merge remote-tracking branch 'upstream/main' into cow_df_from_records
4cf8a5c 
# Conflicts:
#	doc/source/whatsnew/v2.0.0.rst
#	pandas/tests/copy_view/test_constructors.py
@phofl phofl merged commit db12473 into pandas-dev:main Mar 17, 2023
@phofl phofl deleted the cow_df_from_records branch March 17, 2023 17:21
@lumberbot-app
Copy link

lumberbot-app bot commented Mar 17, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 db12473eb78b176b90fb8436f2d6e4be4d22f579
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #52029: BUG-CoW: from_records not tracking references when called with df'
  1. Push to a named branch:
git push YOURFORK 2.0.x:auto-backport-of-pr-52029-on-2.0.x
  1. Create a PR against branch 2.0.x, I would have named this PR:

"Backport PR #52029 on branch 2.0.x (BUG-CoW: from_records not tracking references when called with df)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

phofl added a commit to phofl/pandas that referenced this pull request Mar 17, 2023
@phofl
BUG-CoW: from_records not tracking references when called with df (pa…
a912748 
…ndas-dev#52029)
@phofl phofl mentioned this pull request Mar 17, 2023
Merged
phofl added a commit that referenced this pull request Mar 18, 2023
@phofl
Backport PR #52029 on branch 2.0.x (BUG-CoW: from_records not trackin…
64cc028 
…g references when called with df) (#52055)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Copy / view semantics DataFrame DataFrame data structure
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @jorisvandenbossche