Revert "Re-enable parallel builds in CI" #51952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4d74fbd.
Closed
3 tasks
|
Didn't follow this last week. This breaks other stuff that you want to fix, that's why we are reverting? |
|
Yes
…On Tue, Mar 14, 2023 at 3:59 PM Patrick Hoefler ***@***.***> wrote:
Didn't follow this last week. This breaks other stuff that you want to
fix, that's why we are reverting?
—
Reply to this email directly, view it on GitHub
<#51952 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5UM6EBY5WV6ZWSPYYWHQTW4DZ6ZANCNFSM6AAAAAAVZW7TYM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
ATM I can't maintain the C parts of the datetime code, which is unacceptable. |
|
Sorry that it took me so long, I was going through the initial PR. If I understand it correctly it did not fix anything user visible and might get simpler if we can upstream stuff to NumPy? So should be good to revert, hopefully will get simpler in the future. |
|
This shouldn't be reverted. The whole point of this and the capsule PR is to clean up our symbol management and make an internal API for our extensions. Reverting this puts us back into a place of hacks and guesses until things work. Can we revert this revert? |
|
Fine |
mroeschke
added a commit
to mroeschke/pandas
that referenced
this pull request
Mar 16, 2023
This reverts commit c8ea34c.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #51902
Depends on #51525 which is reverted by #51951