Skip to content

BUG: Count creates result with read_only array #51943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2023
Merged

BUG: Count creates result with read_only array #51943

merged 2 commits into from
Mar 14, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Mar 13, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added this to the 2.0 milestone Mar 13, 2023
jorisvandenbossche
jorisvandenbossche approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phofl phofl merged commit e316f5d into pandas-dev:main Mar 14, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 14, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 14, 2023
@phofl @meeseeksmachine
Backport PR pandas-dev#51943: BUG: Count creates result with read_onl…
7d4ed86 
…y array
mroeschke pushed a commit that referenced this pull request Mar 14, 2023
@meeseeksmachine @phofl
Backport PR #51943 on branch 2.0.x (BUG: Count creates result with re…
5cf184e 
…ad_only array) (#51957)

Backport PR #51943: BUG: Count creates result with read_only array

Co-authored-by: Patrick Hoefler <[email protected]>
@phofl phofl deleted the cow_count_read_only_array branch March 14, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Copy / view semantics
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @jorisvandenbossche