REF: move ExtensionIndex.map to be part of DatetimeLikeArrayMixin.map #51934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
commented
Mar 13, 2023
| # Item "IndexOpsMixin" of "Union[IndexOpsMixin, ExtensionArray, | ||
| # ndarray[Any, Any]]" has no attribute "map" | ||
| return arr.map(mapper, na_action=na_action) # type: ignore[union-attr] | ||
| if isinstance(arr, ExtensionArray): |
There was a problem hiding this comment.
DatetimeArray/DatetimeIndex etc. have numpy dtypes, so using is_extension_array_dtype isn't enough, we need to check for ExtensionArray to reach the .map method of datetime-likes.
5 tasks
mroeschke
approved these changes
Mar 14, 2023
|
Thanks @topper-123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #51809.
ExtensionIndex.mapis only used by the datetime-like indexes (DatetimeIndex.mapetc.) and contains no index-specific functionality, so shouldn't be an index method.By moving this method to
DatetimeLikeArrayMixin.mapwe simplify the code paths quite a bit when dealing withDatetimeArray.mapetc. In the next PR I will makena_action="ignore"work as expected and close #51644.