BUG: Incorrect parsing of ISO 8601 durations strings in Timedelta constructor

[rosstitmarsh]

• Closes BUG: Incorrect parsing of ISO 8601 durations strings in Timedelta constructor #51882
• Closes BUG: Parsing ISO 8601 duration time components with value above 99 throws an error #48122
• Tests added and passed if fixing a bug or adding a new feature
• All code checks passed.
• Added type annotations to new arguments/methods/functions.
• Added an entry in the latest doc/source/whatsnew/v2.1.0.rst file if fixing a bug or adding a new feature.

[github-actions]

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

[mroeschke]

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

[rosstitmarsh]

@mroeschke I would like to reopen this pull request, I have updated it to the main branch. Issues #51882 and #48122 are still not resolved.

[MarcoGorelli]

thanks for your PR

I do feel a bit nervous about this (as I do about the original implementation, tbh...), and think this might be a good case for a parametric test

would it be possible to add some reference implementation, such as isoduration, and then to use hypothesis to generate random tests in which you assert that the output matches that of the reference implementation?

[rosstitmarsh]

would it be possible to add some reference implementation, such as isoduration, and then to use hypothesis to generate random tests in which you assert that the output matches that of the reference implementation?

@MarcoGorelli I agree that is a good idea.
I am struggling with isoduration because it creates duration strings where the number parts can be in scientific notation , this does not seem to be part of ISO8601

[MarcoGorelli]

thanks - maybe there's something else we can use then? will take a look

[mroeschke]

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.