CoW: change ChainedAssignmentError exception to a warning #51926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
approved these changes
Mar 13, 2023
phofl
reviewed
Mar 13, 2023
|
Yes, good catch, updated |
mroeschke
reviewed
Mar 14, 2023
mroeschke
approved these changes
Mar 15, 2023
|
Thanks @jorisvandenbossche |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Mar 15, 2023
…ption to a warning
mroeschke
pushed a commit
that referenced
this pull request
Mar 15, 2023
…r exception to a warning) (#51986) Backport PR #51926: CoW: change ChainedAssignmentError exception to a warning Co-authored-by: Joris Van den Bossche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #51315 for context. Currently the detection gives false positives if the changed assignment comes from cython code. Therefore, changing this to a warning to still allow more broadly testing this without causing failures.