Skip to content

Replace deprecated BadZipfile with BadZipFile #51918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Mar 12, 2023


BadZipfile (with a small f) has been deprecated since Python 3.2, use BadZipFile (big F) instead, added in 3.2.

Does this need a news entry?

@lithomas1 lithomas1 added this to the 2.0 milestone Mar 13, 2023
@lithomas1 lithomas1 added the Compat pandas objects compatability with Numpy or Python functions label Mar 13, 2023
@lithomas1
Copy link
Member

This should be fine, since it's just in the tests.

Thanks @hugovk.

@lithomas1 lithomas1 merged commit b7a6133 into pandas-dev:main Mar 13, 2023
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 13, 2023
@hugovk hugovk deleted the replace-deprecated-BadZipfile branch March 13, 2023 11:58
simonjayhawkins pushed a commit that referenced this pull request Mar 13, 2023
…h BadZipFile) (#51927)

Backport PR #51918: Replace deprecated BadZipfile with BadZipFile

Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants