Skip to content

assert_frame_equal for set #51899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 20, 2023
Merged

assert_frame_equal for set #51899

merged 9 commits into from
Mar 20, 2023

Conversation

jayendra-patil33
Copy link
Contributor

@jayendra-patil33 jayendra-patil33 commented Mar 11, 2023 •
edited
Loading

topper-123
topper-123 reviewed Mar 12, 2023
View reviewed changes
Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Can you add line in whatsnew/v2.1.0.rst about this, under bug fixes/other.

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Mar 13, 2023
@topper-123
Copy link
Contributor

Ping when ready and I'll merge it.

@jayendra-patil33
Copy link
Contributor Author

@topper-123 done

@topper-123 topper-123 added this to the 2.1 milestone Mar 20, 2023
@topper-123 topper-123 merged commit b5aec87 into pandas-dev:main Mar 20, 2023
@topper-123
Copy link
Contributor

Thanks, @jayendra-patil33 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topper-123 topper-123 topper-123 left review comments

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

BUG: assert_frame_equal failed on comparing two not equal Sets ('set' object is not subscriptable)
3 participants
@jayendra-patil33 @topper-123 @mroeschke