Skip to content

GBQ: Updated Documentation, and added method to generic.py #5179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2013

Conversation

jacobschaer
Copy link
Contributor

Added some documentation for GBQ module

@jreback
Copy link
Contributor

jreback commented Oct 10, 2013

i led u astray

move to_gbq to core/frame.py (from core/generic.py)
as you only allow data frames (no series or panels)

@@ -98,6 +98,15 @@ SQL
read_frame
write_frame

SQL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be something else?

@jreback
Copy link
Contributor

jreback commented Oct 11, 2013

@jacobschaer

actually....instead of moving to core/frame.py, why don't you just check that the obj.ndim==2 and otherwise raise NotImlementedError, that way you can easily support a series at some point in the future if you want, and you get a nice error message (and not AttributeError)

@jtratner
Copy link
Contributor

Not sure if that's the best choice. If we did choose to support it later,
introspection on the object in this version would suggest that this exists
and is supported.

@jreback
Copy link
Contributor

jreback commented Oct 11, 2013

@jacobschaer reverting back......so move to_gbq from core/generic.py to core/frame.py...makes the most sense (we have this with to_stata/to_csv/to_sql as they don't make sense generally for non-frames).

@jreback
Copy link
Contributor

jreback commented Oct 14, 2013

@jacobschaer can you fixup?

@jacobschaer
Copy link
Contributor Author

@jreback - Sorry about the delay. Docs should be fixed up, and the to_gbq method is in core/frame.py.

:toctree: generated/

read_gbq
to_gbq
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When rebasing, you will have to add .. currentmodule:: pandas after this line, because now most functions in api.rst are documented from top-level pandas (#5208).

@jreback
Copy link
Contributor

jreback commented Oct 14, 2013

just a small change; pls squash and i'll merge this

@jacobschaer
Copy link
Contributor Author

@jreback - Fixed and squashed.

@jorisvandenbossche - Not entirely sure what needed to be done, but I think I did what you asked.

jreback added a commit that referenced this pull request Oct 15, 2013
GBQ: Updated Documentation, and added method to generic.py
@jreback jreback merged commit 247af41 into pandas-dev:master Oct 15, 2013
@jorisvandenbossche
Copy link
Member

@jacobschaer Indeed, you did what I meant!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants