-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
GBQ: Updated Documentation, and added method to generic.py #5179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
i led u astray move to_gbq to core/frame.py (from core/generic.py) |
@@ -98,6 +98,15 @@ SQL | |||
read_frame | |||
write_frame | |||
|
|||
SQL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be something else?
actually....instead of moving to |
Not sure if that's the best choice. If we did choose to support it later, |
@jacobschaer reverting back......so move |
@jacobschaer can you fixup? |
@jreback - Sorry about the delay. Docs should be fixed up, and the |
:toctree: generated/ | ||
|
||
read_gbq | ||
to_gbq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When rebasing, you will have to add .. currentmodule:: pandas
after this line, because now most functions in api.rst are documented from top-level pandas (#5208).
just a small change; pls squash and i'll merge this |
@jreback - Fixed and squashed. @jorisvandenbossche - Not entirely sure what needed to be done, but I think I did what you asked. |
GBQ: Updated Documentation, and added method to generic.py
@jacobschaer Indeed, you did what I meant! |
Added some documentation for GBQ module