CLN: assorted #51775
Merged
CLN: assorted #51775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Mar 6, 2023
| @@ -789,7 +789,6 @@ Other API changes | |||
| Deprecations | |||
| ~~~~~~~~~~~~ | |||
| - Deprecated parsing datetime strings with system-local timezone to ``tzlocal``, pass a ``tz`` keyword or explicitly call ``tz_localize`` instead (:issue:`50791`) | |||
| - Deprecated silently dropping unrecognized timezones when parsing strings to datetimes (:issue:`18702`) | |||
There was a problem hiding this comment.
Do you know if this commit got accidentally backported at any point?
There was a problem hiding this comment.
after the PR that added this note got merged we agreed the note should be moved rather than the PR backported
mroeschke
reviewed
Mar 6, 2023
| @@ -575,6 +575,8 @@ def test_bytes_exceed_2gb(c_parser_only): | |||
| if parser.low_memory: | |||
| pytest.skip("not a low_memory test") | |||
|
|
|||
| # csv takes 10 seconds to construct, spikes memory to 8GB+, the whole test | |||
There was a problem hiding this comment.
Sidenote: This seems to be more appropriate as an ASV benchmark using peak_mem
mroeschke
approved these changes
Mar 7, 2023
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.closes #34381 by editing to_offset docstring to clarify returned object is BaseOffset subclass