Is ExtensionDtype.type a property or a ClassVar? #51736
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Either way. I like the class-level when it is fixed bc it is less verbose. It's also faster to access (37ns vs 62ns not a huge deal but still) The only way I can imagine it making a difference at runtime is if a user tries to modify it, which is a corner case im not inclined to defined against. If you feel strongly about aligning these for type-checking reasons, fine by me. |
Happy to go with a ClassVar everywhere |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtensionDtype.typeis apropertybut a few (not all) sub-classes define it as a class variable. I assume it should be apropertybut I'm not sure.There are a few more cases where
typeis used a class variable in pandas/core/arrays/floating.py and pandas/core/arrays/integer.py. I will address them but I first wanted to ask whethertypeis supposed to be apropertyor a class variable. @jbrockmendelxref pandas-dev/pandas-stubs#554 (comment)