CI: Add bot to track deprecation prs #51723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
requested review from
jorisvandenbossche,
jbrockmendel,
datapythonista,
mroeschke,
MarcoGorelli,
rhshadrach and
lithomas1
datapythonista
approved these changes
Mar 1, 2023
|
i don't know enough about GH workflows to comment on the implementation, but the idea sounds really neat |
|
+1 for trying this out. |
|
Nice, on board with the idea I'm no security expert, but I guess there's no way for this to be exploited to get the secrets out of it? |
|
I don’t think so, I am basically using the same technique as our assign bot. Also, it’s not possible to trigger the bot again after the pr is merged |
MarcoGorelli
approved these changes
Mar 2, 2023
jbrockmendel
approved these changes
Mar 2, 2023
|
I'll merge this, we can always revert if we get any problems. I have a deprecation pr ready that can test the bot |
mroeschke
reviewed
Mar 4, 2023
| env: | ||
| DEPRECATION_TRACKER_ISSUE: 50578 | ||
| steps: | ||
| - name: Checkout |
There was a problem hiding this comment.
NBD: But probably good to rename this like Add deprecation log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tend to forget to register deprecation prs in our deprecation log. This bot aims to solve this. Every time a PR with the label Deprecate is merged, it adds a new entry to the deprecation log.
In a future version I'd like to add the option to also check enforced deprecations automatically.
One TODO is how to handle PRs where we enforce deprecations:
We could get race conditions in theory, but it is not very likely, so would address if it becomes a problem.
Tried this in my repo and worked reliably
Pinging everyone who is regularly merging prs, hope I did not forget anyone