REF: Remove sanitize_column from _iset_item #51702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Mar 1, 2023
pandas/core/frame.py
Outdated
| arraylike = self._sanitize_column(value) | ||
| self._iset_item_mgr(loc, arraylike, inplace=True) | ||
| def _iset_item(self, loc: int, value: Series) -> None: | ||
| self._iset_item_mgr(loc, value._values, inplace=True) |
There was a problem hiding this comment.
i think this is OK only because iset_item is called only from replace_columnwise which guarantees no reindex is necessary. can you add a comment to that effect?
There was a problem hiding this comment.
Added a comment, we have to keep the copy until reference tracking for setitem works properly (meaning the value that is set into the DataFrame).
|
BTW one of your other recent PRs that avoided passing DataFrame to sanitize_column might make it so that the allow_2d=True passed there could be unnecessary? |
|
I think we could still get there with 2D arrays, not sure though. Would have to check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.this should work ootb. Don't think we need a copy here