Skip to content

ERR: Add explicit error message for isetitem for DataFrame #51701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 1, 2023
Merged

ERR: Add explicit error message for isetitem for DataFrame #51701

merged 3 commits into from
Mar 1, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Feb 28, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

cc @jbrockmendel

jbrockmendel
jbrockmendel approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, does this need a whatsnew?

@phofl
Copy link
Member Author

phofl commented Mar 1, 2023

Doesn't hurt probably, added one

@phofl phofl added this to the 2.1 milestone Mar 1, 2023
@phofl phofl added Indexing Related to indexing on series/frames, not to indexes themselves Error Reporting Incorrect or improved errors from pandas labels Mar 1, 2023
@phofl phofl merged commit 530e460 into pandas-dev:main Mar 1, 2023
@phofl phofl deleted the isetitem_dimensions branch March 1, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @jbrockmendel