BUG: DataFrame.stack losing EA dtypes with multi-columns and mixed dtypes #51691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemanley
added
Bug
Reshaping
jbrockmendel
reviewed
Mar 3, 2023
pandas/core/reshape/reshape.py
Outdated
| if frame._is_homogeneous_type and is_extension_array_dtype( | ||
| frame.dtypes.iloc[0] | ||
| ): | ||
| subset = this[this.columns[loc]] |
There was a problem hiding this comment.
this.iloc[:, loc]? i think in case where loc is a slice this avoids a copy
mroeschke
reviewed
Mar 8, 2023
| # TODO(EA2D): we get object dtype because DataFrame.values can't | ||
| # be an EA | ||
| expected = df.astype(object).stack("station") | ||
| expected = ( |
There was a problem hiding this comment.
For this expected could you construct without the astype(object) e.g. pd.DataFrame(...)?
mroeschke
approved these changes
Mar 9, 2023
|
Thanks @lukemanley |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.1.0.rstfile if fixing a bug or adding a new feature.